Envelope-to: christian@ssf.com.mx
Delivery-date: Mon, 04 Jan 2016 11:56:32 -0600
Date: Mon, 04 Jan 2016 11:55:50 -0600
From: Rogelio Delgado <issuessicom@gmail.com>
Reply-To: noreply@108.161.137.201
To: christian@ssf.com.mx
Message-ID: <568ab22632efd_9203fe8a971cf8811646b@develop.mail>
References: <merge_request_117@108.161.137.201>
Subject: G4S | Modificacion integracion clientes/unidades tomza (#69)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_568ab22631319_9203fe8a971cf88116378";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
 
 Content preview:  New comment for Merge Request 69 http://108.161.137.201:9000/Rogelio/g4s/merge_requests/69#note_174
    Rogelio Delgado [...] 
 
 Content analysis details:   (-0.8 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail provider
                             (issuessicom[at]gmail.com)
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 108.161.137.201]
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 WEIRD_PORT             URI: Uses non-standard port number for HTTP
  0.0 NORMAL_HTTP_TO_IP      URI: URI host has a public dotted-decimal IPv4
                             address
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
                             trust
                             [209.85.218.42 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
                             [209.85.218.42 listed in wl.mailspike.net]
 -0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO


----==_mimepart_568ab22631319_9203fe8a971cf88116378
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

New comment for Merge Request 69

http://108.161.137.201:9000/Rogelio/g4s/merge_requests/69#note_174


Rogelio Delgado

La validaci=C3=B3n me parece que deber=C3=ADa estar m=C3=A1s encapsulada,=
 siento que est=C3=A1 muy a modo "parche" (si lo se, la funcionalidad =

completa es un parche). Podr=C3=ADa ser que se moviera a un m=C3=A9todo l=
lamado "getCodeForG4SClient" o algo as=C3=AD que ser=C3=A1 donde se haga =

de una u otra forma tomando el cliente como criterio, en este caso, Tomza=
 o no tomza. Si en un futuro, por azares del destino
necesitamos hacer una l=C3=B3gica diferente dependiendo el cliente, tendr=
=C3=ADamos que modificar este m=C3=A9todo.


----==_mimepart_568ab22631319_9203fe8a971cf88116378
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html lang=3D'en'>
<head>
<meta content=3D'text/html; charset=3Dutf-8' http-equiv=3D'Content-Type'>=

<title>
GitLab
</title>
</meta>
</head>
<style>
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
</style>
<body>
<div class=3D'content'>
<p class=3D'details'>
New comment on diff for
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/69#note=
_174">BrokerGaspar-project/GasparIntegration/src/main/scala/mx/ssf/sicom/=
gasparIntegration/commands/equipmentCommands/UploadReceptionUnitsCommand.=
scala</a>
:
</p>
<div>
<p>La validaci=C3=B3n me parece que deber=C3=ADa estar m=C3=A1s encapsula=
da, siento que est=C3=A1 muy a modo &quot;parche&quot; (si lo se, la func=
ionalidad =

completa es un parche). Podr=C3=ADa ser que se moviera a un m=C3=A9todo l=
lamado &quot;getCodeForG4SClient&quot; o algo as=C3=AD que ser=C3=A1 dond=
e se haga =

de una u otra forma tomando el cliente como criterio, en este caso, Tomza=
 o no tomza. Si en un futuro, por azares del destino
necesitamos hacer una l=C3=B3gica diferente dependiendo el cliente, tendr=
=C3=ADamos que modificar este m=C3=A9todo.</p>

</div>


</div>
<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
You're receiving this notification because you are a member of the Rogeli=
o Delgado / G4S project team.
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/69#note=
_174">View it on GitLab</a>
</p>
</div>
</body>
</html>

----==_mimepart_568ab22631319_9203fe8a971cf88116378--