Envelope-to: christian@ssf.com.mx
Delivery-date: Sun, 20 Mar 2016 23:09:59 -0600
Date: Sun, 20 Mar 2016 23:09:00 -0600
From: Rogelio Delgado <issuessicom@gmail.com>
Reply-To: noreply@108.161.137.201
To: christian@ssf.com.mx
Message-ID: <56ef81ec9fc24_e1b3f93c1c4a8f88942@develop.mail>
References: <merge_request_293@108.161.137.201>
Subject: G4S | Bug pedidos a equipos desenlazados (#96)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_56ef81ec9be46_e1b3f93c1c4a8f88933b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
 
 Content preview:  New comment for Merge Request 96 http://108.161.137.201:9000/Rogelio/g4s/merge_requests/96#note_562
    Rogelio Delgado [...] 
 
 Content analysis details:   (-0.8 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 108.161.137.201]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
                             trust
                             [209.85.218.43 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail provider
                             (issuessicom[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 WEIRD_PORT             URI: Uses non-standard port number for HTTP
  0.0 NORMAL_HTTP_TO_IP      URI: URI host has a public dotted-decimal IPv4
                             address
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [209.85.218.43 listed in wl.mailspike.net]
X-Spam-Flag: NO


----==_mimepart_56ef81ec9be46_e1b3f93c1c4a8f88933b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

New comment for Merge Request 96

http://108.161.137.201:9000/Rogelio/g4s/merge_requests/96#note_562


Rogelio Delgado

Al mandar llamar esta linea se dejan de hacer dos cosas; no se verifica s=
i:

orderToSave.getEmployeeTruck().getEquipment()

es null. Tampoco se revisa si el equipo obtenido es tipo cilindrera. Si f=
uese cilindrera no se podr=C3=ADa notificar la orden y habr=C3=ADa proble=
mas.

As=C3=AD, se debe revisar por:
Si el equipo es nulo o es cilindrera, entonces se notifica la orden.
Si el equipo est=C3=A1 disponible, entonces se notifica la orden.
Si el equipo no es null y no es cilindrera, entonces NO se notifica la or=
den.

Estos pasos deber=C3=ADan realizarse en un m=C3=A9todo aparte para encaps=
ular esas validaciones.


----==_mimepart_56ef81ec9be46_e1b3f93c1c4a8f88933b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html lang=3D'en'>
<head>
<meta content=3D'text/html; charset=3Dutf-8' http-equiv=3D'Content-Type'>=

<title>
GitLab
</title>
</meta>
</head>
<style>
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
</style>
<body>
<div class=3D'content'>
<p class=3D'details'>
New comment on diff for
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/96#note=
_562">SCGasPAR/SCGasPAR-web/src/main/java/mx/ssf/sicom/scgaspar/web/callC=
enter/presenters/OrderRequestPresenter.java</a>
:
</p>
<div>
<p>Al mandar llamar esta linea se dejan de hacer dos cosas; no se verific=
a si:</p>

<p>orderToSave.getEmployeeTruck().getEquipment()</p>

<p>es null. Tampoco se revisa si el equipo obtenido es tipo cilindrera. S=
i fuese cilindrera no se podr=C3=ADa notificar la orden y habr=C3=ADa pro=
blemas.</p>

<p>As=C3=AD, se debe revisar por:
Si el equipo es nulo o es cilindrera, entonces se notifica la orden.
Si el equipo est=C3=A1 disponible, entonces se notifica la orden.
Si el equipo no es null y no es cilindrera, entonces NO se notifica la or=
den.</p>

<p>Estos pasos deber=C3=ADan realizarse en un m=C3=A9todo aparte para enc=
apsular esas validaciones.</p>

</div>


</div>
<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
You're receiving this notification because you are a member of the Rogeli=
o Delgado / G4S project team.
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/96#note=
_562">View it on GitLab</a>
</p>
</div>
</body>
</html>

----==_mimepart_56ef81ec9be46_e1b3f93c1c4a8f88933b--