Return-path: Envelope-to: javier@ssf.com.mx Delivery-date: Tue, 01 Dec 2015 16:55:51 -0600 Received: from lb01-ash.bitbucket.org ([131.103.20.165]:32303 helo=lb01.bitbucket.org) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86) (envelope-from ) id 1a3tpt-003KQr-ND for javier@ssf.com.mx; Tue, 01 Dec 2015 16:55:51 -0600 Received: from celery-worker-101.ash1.bb-inf.net (node01-c.ash-private.bitbucket.org [172.17.10.43]) by lb01.bitbucket.org (Postfix) with ESMTP id E5209A81E93 for ; Tue, 1 Dec 2015 22:55:10 +0000 (UTC) Received: from celery-worker-101.ash1.bb-inf.net (localhost.localdomain [127.0.0.1]) by celery-worker-101.ash1.bb-inf.net (Postfix) with ESMTP id E46CE111437 for ; Tue, 1 Dec 2015 22:55:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4568413482348726277==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #611: es el catalogo de dependencias de gobierno para el modulo de autogestion (globalgassf/globalnet-app) From: =?utf-8?q?Juan_Gudi=C3=B1o?= To: javier@ssf.com.mx Date: Tue, 01 Dec 2015 22:55:10 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: X-Spam-Status: No, score=-2.9 X-Spam-Score: -28 X-Spam-Bar: -- X-Ham-Report: Spam detection software, running on the system "vishnu.hosting-mexico.net", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/611/es-el-catalogo-de-dependencias-de-gobierno#comment-12347684 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: amazonaws.com] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [131.103.20.165 listed in list.dnswl.org] 0.0 T_SPF_PERMERROR SPF: test of record failed (permerror) -0.6 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [131.103.20.165 listed in wl.mailspike.net] 0.0 HTML_MESSAGE BODY: HTML included in message -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO --===============4568413482348726277== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/611/es-el-catalogo-de-dependencias-de-gobierno#comment-12347684 Juan Gudiño said: hay que evitar dejar la declaración de variables como estas: val variable = ""; En lugar de eso pueden ir después de los imports, junto a las otras 2 variables: formId y modalId, También aprovechando que importaste el GovernmentAgencyCtrl, puedes entonces jalar tanto el permiso como el nombre de la tabla de dicho controlador -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/611/unwatch/javierssf/78525bf60f610e9bdd0eca4dc9ea24a7727c06c5/ --===============4568413482348726277== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
Juan Gudiño commented on pull request #611: es el catalogo de dependencias de gobierno para el modulo de autogestion
app/views/catalogs/governmentAgency/index.scala.html
6 +@import scala.collection.immutable.List;implicit val functionsWrapper = new controllers.commons.FunctionsCollector()
7 +@import views.html.templates.containers._;
8 +@import views.html.templates.containers.widgets._; val tableId = "governmentAgencyTable";
9 +@import views.html.templates.controls.tables._; val editPermission = "edit.catalogs.governmentAgency";
jgudino
Juan Gudiño commented on pull request #611:
es el catalogo de dependencias de gobierno para el modulo de autogestion

hay que evitar dejar la declaración de variables como estas: val variable = ""; En lugar de eso pueden ir después de los imports, junto a las otras 2 variables: formId y modalId, También aprovechando que importaste el GovernmentAgencyCtrl, puedes entonces jalar tanto el permiso como el nombre de la tabla de dicho controlador
View this pull request or add a comment by replying to this email.
10 +@import views.html.templates.controls.buttons._
11 +@import views.html.templates.controls.buttons.crud._
12 +@import views.html.templates.controls.modals._
Unwatch this pull request to stop receiving email updates. Bitbucket
--===============4568413482348726277==--