Envelope-to: julio@ssf.com.mx
Delivery-date: Mon, 14 Dec 2015 23:12:13 -0600
Date: Mon, 14 Dec 2015 23:11:35 -0600
From: Rogelio Delgado <issuessicom@gmail.com>
Reply-To: noreply@108.161.137.201
To: julio@ssf.com.mx
Message-ID: <566fa107b0ab_9203fe8a971cf881023ce@develop.mail>
References: <merge_request_93@108.161.137.201>
Subject: G4S | Bug delete customer (#63)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_566fa1077ddb_9203fe8a971cf88102250";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
 
 Content preview:  New comment for Merge Request 63 http://108.161.137.201:9000/Rogelio/g4s/merge_requests/63#note_138
    Rogelio Delgado [...] 
 
 Content analysis details:   (1.2 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 108.161.137.201]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
                             trust
                             [209.85.214.180 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail provider
                             (issuessicom[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
                             [209.85.214.180 listed in wl.mailspike.net]
  0.0 WEIRD_PORT             URI: Uses non-standard port number for HTTP
  0.0 NORMAL_HTTP_TO_IP      URI: URI host has a public dotted-decimal IPv4
                             address
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
  2.0 KAM_BADIPHTTP          Due to the Storm Bot Network, IPs in emails is bad
X-Spam-Flag: NO


----==_mimepart_566fa1077ddb_9203fe8a971cf88102250
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

New comment for Merge Request 63

http://108.161.137.201:9000/Rogelio/g4s/merge_requests/63#note_138


Rogelio Delgado

Julio, los cambios que realizaste est=C3=A1n bien, sin embargo es un parc=
he. Un DAO no deber=C3=ADa nunca ser null a menos que haya algo extra=C3=B1=
o, que es justamente el caso. Por que digo que no deber=C3=ADa se null?, =
pues por spring, nada mas por eso. Spring se encarga de inyectar la insta=
ncia del DAO correspondiente dentro del ciclo de vida del bean, que en es=
te caso es EquipmentServiceImpl.

Entonces, creo que para reparar esto deber=C3=ADamos ver como se instanci=
a la variable receptionUnitEquipmentDAO. Viendo el c=C3=B3digo, no aparec=
e a anotaci=C3=B3n que le indica a spring que necesita inyectar esta inst=
ancia de dao. Para corregirlo necesitamos agregar la anotaci=C3=B3n @Auto=
wired a la variable de clase.


----==_mimepart_566fa1077ddb_9203fe8a971cf88102250
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html lang=3D'en'>
<head>
<meta content=3D'text/html; charset=3Dutf-8' http-equiv=3D'Content-Type'>=

<title>
GitLab
</title>
</meta>
</head>
<style>
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
</style>
<body>
<div class=3D'content'>
<p class=3D'details'>
New comment on diff for
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/63#note=
_138">SCGasPAR/OperationalServicesImpl/src/main/java/mx/ssf/sicom/operati=
onalServices/servicesImpl/EquipmentServiceImpl.java</a>
:
</p>
<div>
<p>Julio, los cambios que realizaste est=C3=A1n bien, sin embargo es un p=
arche. Un DAO no deber=C3=ADa nunca ser null a menos que haya algo extra=C3=
=B1o, que es justamente el caso. Por que digo que no deber=C3=ADa se null=
?, pues por spring, nada mas por eso. Spring se encarga de inyectar la in=
stancia del DAO correspondiente dentro del ciclo de vida del bean, que en=
 este caso es EquipmentServiceImpl.</p>

<p>Entonces, creo que para reparar esto deber=C3=ADamos ver como se insta=
ncia la variable receptionUnitEquipmentDAO. Viendo el c=C3=B3digo, no apa=
rece a anotaci=C3=B3n que le indica a spring que necesita inyectar esta i=
nstancia de dao. Para corregirlo necesitamos agregar la anotaci=C3=B3n @A=
utowired a la variable de clase.</p>

</div>


</div>
<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
You're receiving this notification because you are a member of the Rogeli=
o Delgado / G4S project team.
<a href=3D"http://108.161.137.201:9000/Rogelio/g4s/merge_requests/63#note=
_138">View it on GitLab</a>
</p>
</div>
</body>
</html>

----==_mimepart_566fa1077ddb_9203fe8a971cf88102250--