Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Wed, 06 May 2015 22:09:46 -0500 Received: from lb01-ash.bitbucket.org ([131.103.20.165]:5331 helo=lb01.bitbucket.org) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85) (envelope-from ) id 1YqCC1-000Tto-Nb for miguel@ssf.com.mx; Wed, 06 May 2015 22:09:45 -0500 Received: from app11.ash-private.bitbucket.org (app11.ash-private.bitbucket.org [172.17.10.27]) by lb01.bitbucket.org (Postfix) with ESMTP id D9106A8291A for ; Thu, 7 May 2015 03:09:46 +0000 (UTC) Received: from app11.ash-private.bitbucket.org (localhost [127.0.0.1]) by app11.ash-private.bitbucket.org (Postfix) with ESMTP id D8A1D260133 for ; Thu, 7 May 2015 03:09:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9036295471575405656==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #201: Requisicion y Detalle de requisicion (globalgassf/globalnet) From: "Ricardo Sansores" To: miguel@ssf.com.mx Date: Thu, 07 May 2015 03:09:46 -0000 Auto-Submitted: auto-generated Message-ID: References:

Precedence: bulk In-Reply-To: --===============9036295471575405656== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet/pull-request/201/requisicion-y-detalle-de-requisicion#comment-6707165 Ricardo Sansores said: No me queda claro porqué el método regresa null. De hecho, no suele ser recomendable regresar nulos en los métodos para evitar NullPointerExceptions. Cuando no es posible evitar regresar un null por una u otra razón hay que documentar de forma clara los casos en que se puede regresar nulo. -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet/pull-request/201/unwatch/miguelssf/227040c70998db5fb99dd488deb32b6be69c7311/ --===============9036295471575405656== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

app/controllers/RequisitionController.java

     @Override

     protected Content getContent(Form<Requisition> form) {

-        return views.html.accountingModule.requisition.render(form);

+        return null;

Ricardo Sansores commented on pull request #201:

Requisicion y Detalle de requisicion

No me queda claro porqué el método regresa null. De hecho, no suele ser recomendable regresar nulos en los métodos para evitar NullPointerExceptions. Cuando no es posible evitar regresar un null por una u otra razón hay que documentar de forma clara los casos en que se puede regresar nulo.

View this pull request or add a comment by replying to this email.

}

-    /**

Unwatch this pull request to stop receiving email updates.

--===============9036295471575405656==--