Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Wed, 06 May 2015 22:13:03 -0500 Received: from lb01-ash.bitbucket.org ([131.103.20.165]:40392 helo=lb01.bitbucket.org) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85) (envelope-from ) id 1YqCFD-000UGh-0r for miguel@ssf.com.mx; Wed, 06 May 2015 22:13:03 -0500 Received: from app05.ash-private.bitbucket.org (app05.ash-private.bitbucket.org [172.17.10.16]) by lb01.bitbucket.org (Postfix) with ESMTP id 87A28A82926 for ; Thu, 7 May 2015 03:13:04 +0000 (UTC) Received: from app05.ash-private.bitbucket.org (localhost [127.0.0.1]) by app05.ash-private.bitbucket.org (Postfix) with ESMTP id 86905661DFA for ; Thu, 7 May 2015 03:13:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1371313318285411328==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #201: Requisicion y Detalle de requisicion (globalgassf/globalnet) From: "Ricardo Sansores" To: miguel@ssf.com.mx Date: Thu, 07 May 2015 03:13:04 -0000 Auto-Submitted: auto-generated Message-ID: References:

Precedence: bulk In-Reply-To: --===============1371313318285411328== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet/pull-request/201/requisicion-y-detalle-de-requisicion#comment-6707198 Ricardo Sansores said: Comentar con javadoc. En la documentación se debe indicar la intención del método. No se si el nombre del método es el ideal, con el nombre GoToIndex me hace pensar que se va a la ruta "/", si más bien regresa a la página base de la pantalla de requisiciones yo le pondría goToRequisicionesIndex o goToRequisicionesMain. -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet/pull-request/201/unwatch/miguelssf/227040c70998db5fb99dd488deb32b6be69c7311/ --===============1371313318285411328== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

app/controllers/RequisitionController.java

-     */

-    public Result goToTemplate() {

-        return ok(getContent(requisitionForm));

+    public Result goToIndex() {

Ricardo Sansores commented on pull request #201:

Requisicion y Detalle de requisicion

Comentar con javadoc. En la documentación se debe indicar la intención del método. No se si el nombre del método es el ideal, con el nombre GoToIndex me hace pensar que se va a la ruta "/", si más bien regresa a la página base de la pantalla de requisiciones yo le pondría goToRequisicionesIndex o goToRequisicionesMain.

View this pull request or add a comment by replying to this email.

+

+        return redirect(controllers.routes.RequisitionDetailController.goToTemplate());

}

Unwatch this pull request to stop receiving email updates.

--===============1371313318285411328==--