Envelope-to: miguel@ssf.com.mx
Delivery-date: Wed, 25 Nov 2015 22:00:46 -0600
Date: Wed, 25 Nov 2015 22:00:06 -0600
From: Rogelio Delgado <issuessicom@gmail.com>
Reply-To: noreply@108.161.137.201
To: miguel@ssf.com.mx
Message-ID: <565683c6762f_9203fe8a9720b7480211@develop.mail>
References: <merge_request_70@108.161.137.201>
Subject: iCopAPI | Change for calculate locations (#1)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_565683c65985_9203fe8a9720b74801f0";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
 
 Content preview:  New comment for Merge Request 1 http://108.161.137.201:9000/Rogelio/icopapi/merge_requests/1#note_111
    Rogelio Delgado [...] 
 
 Content analysis details:   (1.2 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 108.161.137.201]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
                             trust
                             [209.85.214.176 listed in list.dnswl.org]
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail provider
                             (issuessicom[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
                             [209.85.214.176 listed in wl.mailspike.net]
  0.0 WEIRD_PORT             URI: Uses non-standard port number for HTTP
  0.0 NORMAL_HTTP_TO_IP      URI: URI host has a public dotted-decimal IPv4
                             address
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
  2.0 KAM_BADIPHTTP          Due to the Storm Bot Network, IPs in emails is bad
X-Spam-Flag: NO


----==_mimepart_565683c65985_9203fe8a9720b74801f0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

New comment for Merge Request 1

http://108.161.137.201:9000/Rogelio/icopapi/merge_requests/1#note_111


Rogelio Delgado

Si te fijas, ya hay un @Autowired para ComplaintService, que se supone qu=
e es donde va toda la l=C3=B3gica de negocio. Aqu=C3=AD est=C3=A1s utiliz=
ando un Repository directamente en el Controller, por lo que te est=C3=A1=
s brincando la capa de servicios. Lo conveniente aqu=C3=AD es hacer m=C3=A9=
todos en el Servicio que manden llamar al Repositorio y respetar la arqui=
tectura por capas.


----==_mimepart_565683c65985_9203fe8a9720b74801f0
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html lang=3D'en'>
<head>
<meta content=3D'text/html; charset=3Dutf-8' http-equiv=3D'Content-Type'>=

<title>
GitLab
</title>
</meta>
</head>
<style>
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
</style>
<body>
<div class=3D'content'>
<p class=3D'details'>
New comment on diff for
<a href=3D"http://108.161.137.201:9000/Rogelio/icopapi/merge_requests/1#n=
ote_111">src/main/java/mx/ssf/icopapi/controllers/ClaimantController.java=
</a>
:
</p>
<div>
<p>Si te fijas, ya hay un @Autowired para ComplaintService, que se supone=
 que es donde va toda la l=C3=B3gica de negocio. Aqu=C3=AD est=C3=A1s uti=
lizando un Repository directamente en el Controller, por lo que te est=C3=
=A1s brincando la capa de servicios. Lo conveniente aqu=C3=AD es hacer m=C3=
=A9todos en el Servicio que manden llamar al Repositorio y respetar la ar=
quitectura por capas.</p>

</div>


</div>
<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
You're receiving this notification because you are a member of the Rogeli=
o Delgado / iCopAPI project team.
<a href=3D"http://108.161.137.201:9000/Rogelio/icopapi/merge_requests/1#n=
ote_111">View it on GitLab</a>
</p>
</div>
</body>
</html>

----==_mimepart_565683c65985_9203fe8a9720b74801f0--