Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Tue, 29 Mar 2016 11:01:06 -0600 Received: from o1678990x3.outbound-mail.sendgrid.net ([167.89.90.3]:61044) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_1) (envelope-from ) id 1akx0i-002tOx-82 for miguel@ssf.com.mx; Tue, 29 Mar 2016 11:01:05 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bitbucket.org; h=content-type:mime-version:subject:from:to:references:in-reply-to; s=s1; bh=k6Dd/CjAMQPnizCW95zzqq2OCF0=; b=uEYd4iBL61gpIQhg/ML5mc8 zDvrJIfqSZQgGDZufSrxxOpr26ATyd+gVxg63JKZPNeeIbZiA0qgP2ESOHqL/p/p W8QrV+itLlpltUWbYiOG/0QMU4EM3X1/XNwwIec1WMKqIQ1usRwaJbIhkHLvXTy6 gwWlCV34COZpYcJhyOZ4= Received: by filter0654p1mdw1.sendgrid.net with SMTP id filter0654p1mdw1.12311.56FAB49AA 2016-03-29 17:00:10.053436269 +0000 UTC Received: from celery-worker-102.ash1.bb-inf.net (mail-ash.bitbucket.org [104.192.143.195]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id 0XAX7ksbS76mGJ93oo8TYA for ; Tue, 29 Mar 2016 17:00:10.076 +0000 (UTC) Received: from celery-worker-102.ash1.bb-inf.net (localhost.localdomain [127.0.0.1]) by celery-worker-102.ash1.bb-inf.net (Postfix) with ESMTP id C7989F67EB for ; Tue, 29 Mar 2016 17:00:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7988950507687389541==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #96: Traidos cambios de version 2 (globalgassf/globalnet3) From: "Alexander Garcia" To: miguel@ssf.com.mx Date: Tue, 29 Mar 2016 17:00:09 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: X-SG-EID: jcizN1ZJXGzc0OL9Q7wZ4g3GQhOSGfYMdoZYX2+1YtcYYXK5TeQFnmBV6kbIyaaShFD9Z2nlNNW+8M bnT/QSsV0p3k6D8IJDksdZuOx0d23+0OnSsVYEsRrnawf8qj6cGk2MA6e4miEYQvVGQXszvbXRb43T 7FPK4inxL3yRI9FMPHEs8T9gDMdFBvw8RakYqJJJFdydPvsTxFNJ2r7USM2SOTKfFM9up8CR+QnK73 Bc8jnwty8DYOdvVrSd046G X-Spam-Status: No, score=-0.1 X-Spam-Score: 0 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "vishnu.hosting-mexico.net", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/96/traidos-cambios-de-version-2#comment-16411979 [...] Content analysis details: (-0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: cloudfront.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [167.89.90.3 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [167.89.90.3 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO --===============7988950507687389541== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/96/traidos-cambios-de-version-2#comment-16411979 Alexander Garcia said: En este metodo y los involucrados, podrias ver si el user se utiliza para algo mas que asignarlo a la nota, en caso de que solo se use para eso, cambia la firma del metodo, haz que en vez de recibir el String user, reciba el UUID que tambien se encuentra en la session, y en note.user haces un new User(id), asi evitamos esa consulta. -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet3/pull-requests/96/unwatch/miguelssf/550b27d8065c7f700ede37cae268ac94daf79a80/ --===============7988950507687389541== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
Alexander Garcia commented on pull request #96: Traidos cambios de version 2
app/mx/ssf/globalgas/services/income/sale/SaleServ.java
974 977 portatilSale = (PortatilSale) deleteNoteFromSale(note.id);
975 978 }
976 979 note.status = Note.STATUS_NOTE.CAPTURADA;
977 980 note.user = userDAO.findById(userId);
xander-ssf
Alexander Garcia commented on pull request #96:
Traidos cambios de version 2

En este metodo y los involucrados, podrias ver si el user se utiliza para algo mas que asignarlo a la nota, en caso de que solo se use para eso, cambia la firma del metodo, haz que en vez de recibir el String user, reciba el UUID que tambien se encuentra en la session, y en note.user haces un new User(id), asi evitamos esa consulta.
View this pull request or add a comment by replying to this email.
978 981 note.details = new HashSet<>();
979 982 note.paymentType = paymentTypeDAO.findById(note.paymentType.id);
980 - note.account = account;
Unwatch this pull request to stop receiving email updates. Bitbucket
--===============7988950507687389541==--