Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Tue, 29 Mar 2016 11:19:49 -0600 Received: from o1678990x3.outbound-mail.sendgrid.net ([167.89.90.3]:36657) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_1) (envelope-from ) id 1akxIv-0033nq-5F for miguel@ssf.com.mx; Tue, 29 Mar 2016 11:19:49 -0600 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bitbucket.org; h=content-type:mime-version:subject:from:to:references:in-reply-to; s=s1; bh=huQKpARouMS3uKLxdSzlNHasytY=; b=UZEMcrdDWyL204LKHKmfOyd 5b3zJjmpJzgfs0CRIkDitY7Uqpp9mdo1kqd9fCQ/pVZr2mvtp1jcNt8qdJDDccAw CXTzopb7MwwHLSxSrAY47ElywBb7/uIdkbQLMq+BFQQ9kOJhoztseL471heBng33 pWNy7XDXvVsipAyTh6o4= Received: by filter0436p1mdw1.sendgrid.net with SMTP id filter0436p1mdw1.29729.56FAB90782 2016-03-29 17:19:03.930584928 +0000 UTC Received: from celery-worker-102.ash1.bb-inf.net (mail-ash.bitbucket.org [104.192.143.195]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id 2bzW7oDkTniE-mhHTA2Vtw for ; Tue, 29 Mar 2016 17:19:03.444 +0000 (UTC) Received: from celery-worker-102.ash1.bb-inf.net (localhost.localdomain [127.0.0.1]) by celery-worker-102.ash1.bb-inf.net (Postfix) with ESMTP id 4F20CF67E5 for ; Tue, 29 Mar 2016 17:19:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8960901570781962216==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #127: Pull 698 App No mergear se necesita funcionalidad de otro branch anterior (globalgassf/globalnet3) From: =?utf-8?q?Juan_Gudi=C3=B1o?= To: miguel@ssf.com.mx Date: Tue, 29 Mar 2016 17:19:02 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: X-SG-EID: jcizN1ZJXGzc0OL9Q7wZ4g3GQhOSGfYMdoZYX2+1Ytesax/jTSvlcpaQWSaAlrfCabrC/0KEP7Mzl5 Yk574VYtSz2PdeFBW9fBPmyUWv1b43vWp46/NIIg6qhmbyX3o5QIaKxe4+9+3eI87X0w9D49w2tAKD XzkQedWoOvRvw6HkL72+t1AFsJ84ySOAVvPWGr6jp6VsHwzGXqGvVO7NyAOJKUQK+jkn696icZhYWd c= X-Spam-Status: No, score=-0.1 X-Spam-Score: 0 X-Spam-Bar: / X-Ham-Report: Spam detection software, running on the system "vishnu.hosting-mexico.net", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/127/pull-698-app-no-mergear-se-necesita#comment-16412854 [...] Content analysis details: (-0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: amazonaws.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [167.89.90.3 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [167.89.90.3 listed in wl.mailspike.net] 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO --===============8960901570781962216== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" content-transfer-encoding: quoted-printable --- you can reply above this line ---=0D =0D New comment on pull request:=0D =0D https://bitbucket.org/globalgassf/globalnet3/pull-requests/127/pull-698-app= -no-mergear-se-necesita#comment-16412854=0D =0D Juan Gudi=C3=B1o said:=0D =0D el e.getMessage(); en un catch de Exception es una muy mala pr=C3=A1ctica, = ya que podr=C3=ADa ocasionar un NullPointerException en el momento en que e= l flujo de la aplicaci=C3=B3n te traiga a esta linea por un Error que no co= ntiene mensaje (cosa com=C3=BAn) y al llegar al e.getMessage tronar=C3=A1 a= l acceder a una propiedad inexistente, adem=C3=A1s veo que arriba en el add= ErrorLogger se invoca al session().get(); esto actualmente es incorrecto ya= que el AuthCtrl provee funcionalidad para obtener el id de planta o mejor = a=C3=BAn el factoryName.=0D =0D Asi que no hay que olvidar 2 cosas: NO usar .getMessage en el catch de Exce= ption (=C3=BAnicamente aqu=C3=AD porque no sabes de que Excepci=C3=B3n est= =C3=A1 derivando) y evitar usar el session(), en lugar de eso llamar el Aut= hCtrl con sus diversos m=C3=A9todos=0D =0D --=0D =0D Unwatch this pull request to stop receiving email updates:=0D https://bitbucket.org/globalgassf/globalnet3/pull-requests/127/unwatch/migu= elssf/b012cb0ba584f789dd7be58d0511549a5d42819c/ --===============8960901570781962216== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" content-transfer-encoding: quoted-printable =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D
=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D
=0D =0D =0D =0D Juan Gudi=C3=B1o commented on pull request #127: Pull 698 App No mergea= r se necesita funcionalidad de otro branch anterior =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D =0D =0D =0D =0D
app/controllers/i= nvoice/InvoiceCtrl.java
=0D
=0D =0D =0D =0D =0D =0D =0D =0D
236249=0D return badRequest(result);
=0D
=0D =0D =0D =0D =0D = =0D =0D =0D
237250=0D }catch (Exception e){
=0D
=0D =0D =0D =0D =0D =0D =0D =0D
238251=0D GlobalNetException.addErrorLogger(InvoiceCtrl.class, e, session().get(FACTORY_ID_KEY));
=0D
=0D =0D =0D =0D =0D =0D =0D =0D
252=0D + data=3Ddata+"|"+e.getMessage(<= wbr>);
=0D
=0D
=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D 3D"jgudino"=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D Juan Gudi=C3=B1o commented on pull= request #127:=0D =0D =0D
=0D Pull 698 App No mergear se = necesita funcionalidad de otro branch anterior =0D
=0D

el e.getMessage(); en un catch de Exception es una mu= y mala pr=C3=A1ctica, ya que podr=C3=ADa ocasionar un NullPointerException = en el momento en que el flujo de la aplicaci=C3=B3n te traiga a esta linea = por un Error que no contiene mensaje (cosa com=C3=BAn) y al llegar al e.get= Message tronar=C3=A1 al acceder a una propiedad inexistente, adem=C3=A1s ve= o que arriba en el addErrorLogger se invoca al session().get(); esto actual= mente es incorrecto ya que el AuthCtrl provee funcionalidad para obtener el= id de planta o mejor a=C3=BAn el factoryName.

=0D

Asi que no ha= y que olvidar 2 cosas: NO usar .getMessage en el catch de Exception (=C3=BA= nicamente aqu=C3=AD porque no sabes de que Excepci=C3=B3n est=C3=A1 derivan= do) y evitar usar el session(), en lugar de eso llamar el AuthCtrl con sus = diversos m=C3=A9todos

=0D =0D
=0D
=0D =0D =0D =0D View this pull request or ad= d a comment by replying to this email.=0D =0D =0D
=0D
=0D
=0D
=0D =0D =0D =0D =0D =0D =0D
239253=0D e.printStackTrace();=0D
=0D
=0D =0D =0D =0D =0D =0D =0D =0D
240254=0D return badRequest(Messages.get(ERROR_UNKNOWN));
=0D
=0D =0D =0D =0D =0D = =0D =0D =0D
241= 255=0D }
=0D
=0D =0D
=0D
=0D
=0D
=0D =0D =0D =0D =0D =0D =0D =0D =0D
=0D =0D =0D =0D =0D =0D =0D Unwatch this pull requ= est to stop receiving email updates.=0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D =0D 3D"Bitbucket"=0D =0D
=0D
=0D
=0D =20=20 3D"" =0D --===============8960901570781962216==--