Envelope-to: miguel@ssf.com.mx
Delivery-date: Tue, 29 Mar 2016 16:53:15 -0600
Content-Type: multipart/alternative;
 boundary="===============9080280106044267402=="
MIME-Version: 1.0
Subject: Re: [Bitbucket] Pull request #135: Pullapp721optimizacionembarques
 (globalgassf/globalnet3)
From: =?utf-8?q?Juan_Gudi=C3=B1o?= <pullrequests-reply@bitbucket.org>
To: miguel@ssf.com.mx
Date: Tue, 29 Mar 2016 22:52:26 -0000
Auto-Submitted: auto-generated
Message-ID: <prcomment-16425748@bitbucket.org>
References: <pr-globalgassf/globalnet3/135@bitbucket.org>
 <pr-globalgassf/globalnet3/135@bitbucket.org>
Precedence: bulk
In-Reply-To: <pr-globalgassf/globalnet3/135@bitbucket.org>
 
 Content preview:  --- you can reply above this line --- New comment on pull
   request: https://bitbucket.org/globalgassf/globalnet3/pull-requests/135/pullapp721optimizacionembarques#comment-16425748
    [...] 
 
 Content analysis details:   (-0.1 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: bitbucket.org]
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
                             trust
                             [167.89.90.3 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [167.89.90.3 listed in wl.mailspike.net]
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO

--===============9080280106044267402==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
content-transfer-encoding: quoted-printable

--- you can reply above this line ---=0D
=0D
New comment on pull request:=0D
=0D
https://bitbucket.org/globalgassf/globalnet3/pull-requests/135/pullapp721op=
timizacionembarques#comment-16425748=0D
=0D
Juan Gudi=C3=B1o said:=0D
=0D
el LOGICAL_REMOVED que debes mandar es NO, ya que te interesa saber si hay =
registros que tengan ese folio y que NO est=C3=A9n eliminados l=C3=B3gicame=
nte=0D
=0D
--=0D
=0D
Unwatch this pull request to stop receiving email updates:=0D
https://bitbucket.org/globalgassf/globalnet3/pull-requests/135/unwatch/migu=
elssf/82ffcc2e42a4c905ae0e72d6b8e365eb947d81ab/

--===============9080280106044267402==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
content-transfer-encoding: quoted-printable

<!DOCTYPE HTML>=0D
<html>=0D
  <head>=0D
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8=
" />=0D
    =0D
  </head>=0D
  <body style=3D"font: 14px/1.4285714 Arial, sans-serif; color: #333;">=0D
    <table style=3D"width: 100%; border-collapse: collapse;">=0D
      <tbody>=0D
        <tr>=0D
          <td style=3D"background: #f5f5f5; padding: 10px 10px 0; font: 14p=
x/1.4285714 Arial, sans-serif;">=0D
            <table style=3D"width: 100%; border-collapse: collapse;">=0D
              <tbody>=0D
                =0D
                =0D
                =0D
                =0D
                  =0D
                     <tr>=0D
  <td id=3D"main" class=3D"comment-container no-box" style=3D"font: 14px/1.=
4285714 Arial, sans-serif; padding: 0; background-color: #ffffff; border-ra=
dius: 5px">=0D
    <div style=3D"border: none; border-radius: 5px; padding: 0; background:=
 #f5f5f5">=0D
      <table style=3D"width: 100%; border-collapse: collapse">=0D
        <tbody>=0D
          <tr>=0D
            <td class=3D"main-comment" style=3D"font: 14px/1.4285714 Arial,=
 sans-serif; padding: 0">=0D
              <div style=3D"border: 1px solid #ccc; border-radius: 5px; bac=
kground-color: #fff; padding: 0">=0D
                =0D
<span style=3D"display: none; display: none !important;">=0D
  =0D
    Juan Gudi=C3=B1o commented on pull request #135: Pullapp721optimizacion=
embarques=0D
  =0D
</span>=0D
<table style=3D"width: 100%; border-collapse: collapse">=0D
  <tbody>=0D
    =0D
      <tr>=0D
        <td class=3D"comment-filename" style=3D"font: 14px/1.4285714 Arial,=
 sans-serif; padding: 0">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td style=3D"font: 14px/1.4285714 Arial, sans-serif; paddin=
g: 10px; background: #f5f5f5; border-radius: 5px 5px 0 0">app/mx/ssf/global=
gas/services/inventory/ShipmentServ.java</td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
    =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line common first" style=3D"font: 14px/1.4285714 =
Arial, sans-serif; padding: 0; font-size: 11px; border-top: 1px solid #ccc"=
>=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'>70</td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'>70</td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #fff'>         }</td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line deletion" style=3D"font: 14px/1.4285714 Aria=
l, sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'>71</td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'></td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #fdd'>-        ShipmentDTO<wbr> toValidateObject =3D <=
wbr>((ShipmentDAO)global<wbr>DAO).findByFolio(shi<wbr>pment.folio, GlobalE<=
wbr>nums.LOGICAL_REMOVED<wbr>.SI);</wbr></wbr></wbr></wbr></wbr></wbr></td>=
=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line deletion" style=3D"font: 14px/1.4285714 Aria=
l, sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'>72</td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'></td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #fdd'>-        if(toValida<wbr>teObject !=3D null &amp=
;&amp; <wbr>!toValidateObject.id<wbr>.equals(shipment.id)<wbr>) {</wbr></wb=
r></wbr></wbr></td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line addition" style=3D"font: 14px/1.4285714 Aria=
l, sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'></td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'>71</td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #cfc'>+        Integer toV<wbr>alidateObject =3D ((Sh<=
wbr>ipmentDAO)globalDAO)<wbr>.countByFolioAndLogi<wbr>calRemoved(shipment.<=
wbr>folio, GlobalEnums.L<wbr>OGICAL_REMOVED.SI);</wbr></wbr></wbr></wbr></w=
br></wbr></td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
        <tr>=0D
          <td class=3D"line-comment" style=3D"font: 14px/1.4285714 Arial, s=
ans-serif; padding: 10px; background: #f5f5f5; border-top: 1px solid #ccc; =
border-bottom: 1px solid #ccc">=0D
            <div style=3D"border: 1px solid #ccc; background: #fff; padding=
: 20px; border-radius: 5px">=0D
              <table style=3D"width: 100%; border-collapse: collapse">=0D
                <tbody>=0D
                  <tr>=0D
                    =0D
                      =0D
=0D
<td class=3D"comment" style=3D"font: 14px/1.4285714 Arial, sans-serif; padd=
ing: 0">=0D
  <table style=3D"width: 100%; border-collapse: collapse">=0D
    <tbody>=0D
      <tr>=0D
        <td class=3D"comment-avatar" style=3D"font: 14px/1.4285714 Arial, s=
ans-serif; padding: 0; width: 32px; vertical-align: top">=0D
          =0D
            =0D
              <img width=3D"32" height=3D"32" alt=3D"jgudino" src=3D"https:=
//bitbucket-assetroot.s3.amazonaws.com/c/photos/2014/Jun/12/jgudino-avatar-=
3845106770-5_avatar.png" style=3D"border-radius: 3px">=0D
            =0D
          =0D
        </td>=0D
        <td class=3D"comment-main" style=3D"font: 14px/1.4285714 Arial, san=
s-serif; padding: 0 0 0 10px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              =0D
                <tr>=0D
                  <td class=3D"comment-user" style=3D"font: 14px/1.4285714 =
Arial, sans-serif; padding: 0; line-height: 1">=0D
                    =0D
                      =0D
                        <strong>Juan Gudi=C3=B1o</strong> commented on pull=
 request #135:=0D
                      =0D
                    =0D
                  </td>=0D
                </tr>=0D
                =0D
                  <tr>=0D
                    <td class=3D"title" style=3D"font: 14px/1.4285714 Arial=
, sans-serif; padding: 5px 0 0; font-weight: bold; line-height: 1.2">=0D
                      <a href=3D"https://bitbucket.org/globalgassf/globalne=
t3/pull-requests/135/pullapp721optimizacionembarques#comment-16425748" styl=
e=3D"color: #3572b0; text-decoration: none">Pullapp721optimizacionembarques=
</a>
                    </td>=0D
                  </tr>=0D
                =0D
              =0D
              <tr>=0D
                <td class=3D"comment-content markup-content" style=3D"font:=
 14px/1.4285714 Arial, sans-serif; padding: 10px 0 15px">=0D
                  =0D
                    <p style=3D"margin-bottom: 0; margin: 10px 0 0 0; paddi=
ng: 0; margin-top: 0">el LOGICAL_REMOVED que debes mandar es NO, ya que te =
interesa saber si hay registros que tengan ese folio y que NO est=C3=A9n el=
iminados l=C3=B3gicamente</p>=0D
                  =0D
                </td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
        <tr>=0D
          <td class=3D"actions secondary" colspan=3D"2" style=3D"font: 14px=
/1.4285714 Arial, sans-serif; padding: 20px 0 0; color: #707070; border-top=
: 1px solid #cccccc; line-height: 1">=0D
            =0D
            =0D
              =0D
                <a href=3D"https://bitbucket.org/globalgassf/globalnet3/pul=
l-requests/135/pullapp721optimizacionembarques#comment-16425748" style=3D"c=
olor: #3572b0; text-decoration: none">View this pull request</a> or add a c=
omment by replying to this email.=0D
              =0D
            =0D
          </td>=0D
        </tr>=0D
      =0D
    </tbody>=0D
  </table>=0D
</td>=0D
=0D
                    =0D
                  </tr>=0D
                </tbody>=0D
              </table>=0D
            </div>=0D
          </td>=0D
        </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line addition" style=3D"font: 14px/1.4285714 Aria=
l, sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'></td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'>72</td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #cfc'>+        if(toValida<wbr>teObject !=3D null &amp=
;&amp; <wbr>toValidateObject &gt;=3D <wbr>1) {</wbr></wbr></wbr></td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line common" style=3D"font: 14px/1.4285714 Arial,=
 sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px'>73</td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'>73</td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #fff'>             throw n<wbr>ew GlobalNetExceptio<wb=
r>n(GlobalNetException<wbr>.ORIGIN.DUPLICATED_E<wbr>NTITY, Messages.get(<wb=
r>"error.inventory.shi<wbr>pment.duplicateFolio<wbr>"));</wbr></wbr></wbr><=
/wbr></wbr></wbr></wbr></td>=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
      <tr>=0D
        <td class=3D"diff-line last common" style=3D"font: 14px/1.4285714 A=
rial, sans-serif; padding: 0; font-size: 11px">=0D
          <table style=3D"width: 100%; border-collapse: collapse">=0D
            <tbody>=0D
              <tr>=0D
                <td class=3D"diff-linenum from" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f=
5f5f5; text-align: center; width: 30px; border-bottom-left-radius: 5px'>74<=
/td>=0D
                <td class=3D"diff-linenum to" style=3D'font: 11px Consolas,=
 Menlo, "Liberation Mono", Courier, monospace; padding: 0; background: #f5f=
5f5; text-align: center; width: 30px; border-right: 1px solid #ccc'>74</td>=
=0D
                <td class=3D"diff-line-content" style=3D'font: 11px Consola=
s, Menlo, "Liberation Mono", Courier, monospace; padding: 0; white-space: p=
re-wrap; background: #fff; border-bottom-right-radius: 5px'>         }</td>=
=0D
              </tr>=0D
            </tbody>=0D
          </table>=0D
        </td>=0D
      </tr>=0D
      =0D
    =0D
  </tbody>=0D
</table>=0D
=0D
              </div>=0D
            </td>=0D
          </tr>=0D
          =0D
  =0D
=0D
        </tbody>=0D
      </table>=0D
    </div>=0D
  </td>=0D
</tr>=0D
=0D
                  =0D
                =0D
                <tr>=0D
                  =0D
=0D
<td style=3D"padding: 20px 0; color: #707070;">=0D
  <table style=3D"width: 100%; border-collapse: collapse;">=0D
    <tbody>=0D
      <tr>=0D
        <td style=3D"padding: 0">=0D
          =0D
            =0D
            =0D
              =0D
              =0D
                =0D
                  <a style=3D"color: #3572b0; text-decoration: none;" href=
=3D"https://bitbucket.org/globalgassf/globalnet3/pull-requests/135/unwatch/=
miguelssf/82ffcc2e42a4c905ae0e72d6b8e365eb947d81ab/">Unwatch this pull requ=
est</a> to stop receiving email updates.=0D
                =0D
              =0D
            =0D
          =0D
          =0D
        </td>=0D
        <td style=3D"padding: 0">=0D
          =0D
            =0D
=0D
  <img width=3D"1" height=3D"1" src=3D"https://bitbucket.org/account/notifi=
cations/mark-read/290514537/d4ae280b68d1e943df42266ba658203d86db3925/">=0D
=0D
=0D
          =0D
        </td>=0D
        <td style=3D"text-align: right; width: 100px; padding: 0">=0D
          <a href=3D"https://bitbucket.org" style=3D"color: #3572b0; text-d=
ecoration: none;">=0D
            <img width=3D"100" height=3D"18" src=3D"https://d3oaxc4q5k2d6q.=
cloudfront.net/m/705c66f23e93/img/email/logo.gif" alt=3D"Bitbucket" />=0D
          </a>=0D
        </td>=0D
      </tr>=0D
    </tbody>=0D
  </table>=0D
</td>=0D
=0D
                </tr>=0D
              </tbody>=0D
            </table>=0D
          </td>=0D
        </tr>=0D
      </tbody>=0D
    </table>=0D
=20=20
<img src=3D"http://link.bitbucket.org/wf/open?upn=3Du0x3fSBqEx-2Fl-2Bmgujqm=
E8Jwb-2FtAhiorRbsVquOOvcTGdl-2F920c2ry3zgPPzZEdrdKzTqy8SY0pIChGbpGzCIn-2BLZ=
3jtf5ajedVS44x83YlFbgSywiUfq468Dmdu4kvC3q5BkvXxJVRLi998qWCuH3dsMe8ZWT2s5D1I=
3DTazr1DyQjcEPwaporxd38ToA3coK8Ge9i8TOpXg9QGJmgWDLYsiQhDsafgOOHs6-2F8fmAuk-=
3D" alt=3D"" width=3D"1" height=3D"1" border=3D"0" style=3D"height:1px !imp=
ortant;width:1px !important;border-width:0 !important;margin-top:0 !importa=
nt;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !impo=
rtant;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 =
!important;padding-left:0 !important;"/>
</body>=0D
</html>


--===============9080280106044267402==--