Return-path: Envelope-to: miguel@ssf.com.mx Delivery-date: Tue, 19 Apr 2016 13:33:28 -0500 Received: from o5.em.bitbucket.org ([167.89.38.16]:17551) by vishnu.hosting-mexico.net with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_1) (envelope-from ) id 1asaSd-003mbI-7O for miguel@ssf.com.mx; Tue, 19 Apr 2016 13:33:27 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bitbucket.org; h=content-type:mime-version:subject:from:to:references:in-reply-to; s=s1; bh=caw2ItmW1hCS3mMQJwvhZ8lNxwU=; b=iFKZmBopJm98+WpxCuvS8A3 0EjOHBpRpeuVZrF32jYSnPU5FVpSIWm/x7dpvFER1qH1OJRmwfJwhL0BfSpNou0f 29hPfn+f3NJgCCx7hNPFI4BXEDsFVtNrdd/MvT/uzR0Znm0Ge1SLIjN5YhRwN12Q rs8t1eWMVcs7+BwuxFHI= Received: by filter0472p1mdw1.sendgrid.net with SMTP id filter0472p1mdw1.5001.571679C272 2016-04-19 18:32:34.959734849 +0000 UTC Received: from celery-worker-103.ash1.bb-inf.net (mail-ash.bitbucket.org [104.192.143.195]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id JlMgdhPdSz66Kf3zFKYMCg for ; Tue, 19 Apr 2016 18:32:34.235 +0000 (UTC) Received: from celery-worker-103.ash1.bb-inf.net (localhost.localdomain [127.0.0.1]) by celery-worker-103.ash1.bb-inf.net (Postfix) with ESMTP id 35231111C12 for ; Tue, 19 Apr 2016 18:32:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4675119553156833966==" MIME-Version: 1.0 Subject: Re: [Bitbucket] Pull request #798: Nuevo atributo en entity unidad para validacion en inventarios, de los porcentajes (globalgassf/globalnet-app) From: "Alexander Garcia" To: miguel@ssf.com.mx Date: Tue, 19 Apr 2016 18:32:34 -0000 Auto-Submitted: auto-generated Message-ID: References: Precedence: bulk In-Reply-To: X-SG-EID: jcizN1ZJXGzc0OL9Q7wZ4g3GQhOSGfYMdoZYX2+1YtdtOqcqkD0KOWXdWoMHP0x2+E3icXNIPm5Ya/ LpAFRnPcG/qTT0FhFXpPIWgf1DrLyTOqC5NGr1rbDfrOITs0207MhdBMxGZ/4vwJZyceLMB7O+YaeK hOYjXk/UcXwga9tse8ZV2VY48K/W6WE3t5o+0iuFfBP3fuyiDlT2JfP3W9G//J6UylvTAmdNSCk6+7 CYxg7L6NZysw9JJOGLuseX X-Spam-Status: No, score=-1.1 X-Spam-Score: -10 X-Spam-Bar: - X-Ham-Report: Spam detection software, running on the system "vishnu.hosting-mexico.net", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see root\@localhost for details. Content preview: --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/798/nuevo-atributo-en-entity-unidad-para#comment-17462139 [...] Content analysis details: (-1.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: atlassian.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [167.89.38.16 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [167.89.38.16 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 HTML_OBFUSCATE_05_10 BODY: Message is 5% to 10% HTML obfuscation 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO --===============4675119553156833966== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit --- you can reply above this line --- New comment on pull request: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/798/nuevo-atributo-en-entity-unidad-para#comment-17462139 Alexander Garcia said: Cambia la logica a que solo regrese boolean y no un DTO -- Unwatch this pull request to stop receiving email updates: https://bitbucket.org/globalgassf/globalnet-app/pull-requests/798/unwatch/miguelssf/2a080e1949ce242f7d1ec839b6977d5965202c7d/ --===============4675119553156833966== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
Alexander Garcia commented on pull request #798: Nuevo atributo en entity unidad para validacion en inventarios, de los porcentajes
app/mx/ssf/globalgas/services/inventory/GasExistenceDetailServ.java
154 + String economicNumber, String unitId, String gasStockId, Double percentage, String type, String inventoryDate) throws ParseException {
154 155 Date date = DateUtils.DATE_PICKER_FORMAT_SHORT.parse(inventoryDate);
155 156 GasExistence existence;
157 + UnitDTO unitDTOValidate = unitDAO.findIFisTransferByEconomicNumber(economicNumber);
xander-ssf
Alexander Garcia commented on pull request #798:
Nuevo atributo en entity unidad para validacion en inventarios, de los porcentajes

Cambia la logica a que solo regrese boolean y no un DTO
View this pull request or add a comment by replying to this email.
158 + if(percentage > 85 && (unitDTOValidate == null || !unitDTOValidate.transfer)) {
159 + throw new GlobalNetException(Messages.get("inventory.inventoryControl.notTransferRange"));
160 + } else if(percentage > 90 && unitDTOValidate.transfer) {
Unwatch this pull request to stop receiving email updates. Bitbucket
--===============4675119553156833966==--