Envelope-to: victor@ssf.com.mx
Delivery-date: Thu, 18 Feb 2016 12:32:47 -0600
Date: Thu, 18 Feb 2016 12:32:04 -0600
From: luis <issuessicom@gmail.com>
Reply-To: noreply@108.161.137.201
To: victor@ssf.com.mx
Message-ID: <56c60e2428faa_f853fede26f1df4773ce@develop.mail>
References: <merge_request_214@108.161.137.201>
Subject: smart-g4s | Totalizer sales (#75)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_56c60e2426d3a_f853fede26f1df47727e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
 
 Content preview:  New comment for Merge Request 75 http://108.161.137.201:9000/luis/smart-g4s/merge_requests/75#note_405
    luis [...] 
 
 Content analysis details:   (0.2 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was blocked.
                             See
                             http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
                              for more information.
                             [URIs: 108.161.137.201]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
                             trust
                             [209.85.214.181 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)
                             [209.85.214.181 listed in wl.mailspike.net]
  1.0 FSL_HELO_FAKE          No description available.
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail provider
                             (issuessicom[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 WEIRD_PORT             URI: Uses non-standard port number for HTTP
  0.0 NORMAL_HTTP_TO_IP      URI: URI host has a public dotted-decimal IPv4
                             address
  0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
                             domain
  0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
 -0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
 -0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-Spam-Flag: NO


----==_mimepart_56c60e2426d3a_f853fede26f1df47727e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

New comment for Merge Request 75

http://108.161.137.201:9000/luis/smart-g4s/merge_requests/75#note_405


luis

No regreses null, regresa una lista vacia, y por buenas practicas crea una variable (Que la tienes mas abajo) y a esa asiganale el valor deseado, posteriormente regresala en la ultima linea, no es bueno tener muchos flujos de control en un mismo metodo (returns)


----==_mimepart_56c60e2426d3a_f853fede26f1df47727e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html lang=3D'en'>
<head>
<meta content=3D'text/html; charset=3Dutf-8' http-equiv=3D'Content-Type'>=

<title>
GitLab
</title>
</meta>
</head>
<style>
  p.details {
    font-style:italic;
    color:#777
  }
  .footer p {
    font-size:small;
    color:#777
  }
</style>
<body>
<div class=3D'content'>
<p class=3D'details'>
New comment on diff for
<a href=3D"http://108.161.137.201:9000/luis/smart-g4s/merge_requests/75#n=
ote_405">Smartg4s/app/src/main/java/mx/ssf/smartg4s/data/daos/sales/SaleD=
AO.java</a>
:
</p>
<div>
<p>No regreses null, regresa una lista vacia, y por buenas practicas crea=
 una variable (Que la tienes mas abajo) y a esa asiganale el valor desead=
o, posteriormente regresala en la ultima linea, no es bueno tener muchos =
flujos de control en un mismo metodo (returns)</p>

</div>


</div>
<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
You're receiving this notification because you are a member of the luis /=
 smart-g4s project team.
<a href=3D"http://108.161.137.201:9000/luis/smart-g4s/merge_requests/75#n=
ote_405">View it on GitLab</a>
</p>
</div>
</body>
</html>

----==_mimepart_56c60e2426d3a_f853fede26f1df47727e--